Qiskit / qiskit / 22894222907

88%

Build Type

push

github

Committed by web-flow

Commit Message

Disable implicit cloning `FromPyObject` impl of `PyCircuitData` (#15786)

`CircuitData` is _in general_ a heavy type to extract, and in general it
_shouldn't_ be too easy to accidentally extract it instead of borrowing
it.  This will become more important for correctness (not just
performance) in the future when the `inner` type becomes
`Arc<RwLock<CircuitData>>`, so we don't end up with spurious clones of
the `Arc`, which would be far harder to detect, because there won't be a
performance hit that goes with it; we'd only be able to detect
subsequent problems in runtime threaded code that attempted to do things
like `Arc::get_mut` on Python instances that _should_ have been unique.

Run Details

8 of 8 new or added lines in 3 files covered. (100.0%)

11 existing lines in 3 files now uncovered.

101168 of 115310 relevant lines covered (87.74%)

1169421.16 hits per line