stacklok / toolhive-cloud-ui / 22895006620

75%

push

github

fix: normalize MCP server names for client config compatibility (#406)

* fix: normalize MCP server names for client config compatibility

Server names in reverse DNS format (e.g. com.toolhive.k8s/github-proxy)
are not supported by Claude Code CLI and other MCP clients. This change:

- Adds normalizeServerName() to replace dots and slashes with dashes,
  ensuring unique and valid identifiers for all MCP clients
- Uses server.title (when available) as the display name across the
  catalog card, table, and detail page, falling back to server.name

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test: update catalog tests to use server title over name

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: always normalize server name for client config, clarify JSDoc

- Always apply normalizeServerName() to both title and name when building
  client configs, so titles with dots or slashes don't break Claude Code CLI
- Update JSDoc to clarify normalization does not guarantee uniqueness across
  names that differ only in "." vs "/"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: update e2e and unit tests to use server title

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: normalize server name inside AddMcpToClientDropdown

Move normalizeServerName call inside the component so all callers
(including future ones) get automatic normalization. Extend the
normalization to handle spaces and any invalid character (not just
dots and slashes), collapsing consecutive dashes and trimming edges.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

202 of 286 branches covered (70.63%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 3 files covered. (100.0%)

369 of 509 relevant lines covered (72.5%)

12.99 hits per line