source-academy / frontend / 22890190739

41%

Build Type

push

github

Committed by web-flow

Commit Message

CSE Machine : Function Descriptions modification for Frame overlap (#3627)

* Added the removeDeadFrames feature
Only dead frames disappear as of right now, for function objects and the rest, work to be done

Animations : will be done by Keying!

* Added the functionality for toggle of dead vs ONLY live for
	function closure objects
	Generic Arrow
	Text (recursively automated)
	Arrays and hence pairs as well

* Fix : Removed gaps
Finally processed the logic by recomputing the envTree for the specific step when the toggle is on

* Fix : CI format errors and made it from checkbox -> onClick button!

* Fix : Toggle -> One time cleanup

* Changed from Hide -> Clear and the icon

* Fixed the following errors and implemented suggestions
1. Fixed the snapshot and lint erros
2. Added the disable feature (as suggested by @sayomaki) where to suggest that its CLEAR and not HIDE, we disable after pressing once!!
3. Changed all instances of hide to clear in our current implementation!

* Fixed tsc error

* Fixed the sentry bot suggestion

* Fixed the error where the frames WERE not moving due to the Layout team's invariant!
Now the frames do move by violating their invariant ONLY if the Clear mode is ON

* Version 1

* Version 2

* Added the following functionalities
1. Capped out the func desc box's widths
2. Click to reveal FULL length descriptions in normal mode
3. Fixed gaps between the FRAMES in PRINTABLE mode

* Fixed a bug where the gap between two frames was not dynamically being set and was capped out!
1. This makes every other test case which we have made look MUCH better!
2. Secondly, we also fixed a bug where recursive closure objects' description boxes' width and length was NOT being
	accounted for

* Fixed format error

* cse layout: normalize frame width accounting and add printable fn description spacing

- normalize Frame width semantics:
  - totalWidth now represents only frame block width
  - totalDataWidth is computed as true overflow beyond fr... (continued)

Run Details

2210 of 6313 branches covered (35.01%)

Branch coverage included in aggregate %.

72 of 112 new or added lines in 10 files covered. (64.29%)

3 existing lines in 3 files now uncovered.

5402 of 12205 relevant lines covered (44.26%)

27.87 hits per line