pmcelhaney / counterfact / 22882848157

83%

main: 83%

Pull #1524

github

Fix root middleware not being executed for all routes

The recurse() function in registry.ts traversed paths as:
/admin/users → /admin → "" → null, never checking "/".
Root middleware is registered at key "/" by the module-loader,
so it was never applied.

Fix: change nextPath calculation to traverse through "/" instead
of "", so traversal goes: /admin/users → /admin → / → null.

Also update tests to use "/" key for root middleware (consistent
with how module-loader registers it), and add a test specifically
for the root middleware case described in the issue.

Co-authored-by: pmcelhaney <51504+pmcelhaney@users.noreply.github.com>

1272 of 1423 branches covered (89.39%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

4053 of 5000 relevant lines covered (81.06%)

60.04 hits per line