supabase / supabase-swift / 22873381715

80%

push

github

fix(realtime): use URLRequest headers instead of httpAdditionalHeaders for WebSocket (#920)

* fix(realtime): store continuation before resuming WebSocket task

The `connect()` method called `task.resume()` before storing the
`CheckedContinuation`. If the connection fails quickly (common on iOS
with certain network conditions), the delegate fires before the
continuation is set, causing either a force-unwrap crash or a silently
dropped error.

This change stores the continuation first, then resumes the task,
ensuring the delegate callbacks always have a valid continuation to
resume.

Fixes #919

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(realtime): use URLRequest headers instead of httpAdditionalHeaders for WebSocket

Setting headers via `URLSessionConfiguration.httpAdditionalHeaders` interferes
with the WebSocket upgrade handshake on iOS, causing -1005 "The network
connection was lost" errors. This is a known iOS limitation where
httpAdditionalHeaders can corrupt the HTTP upgrade negotiation.

The fix passes headers via URLRequest instead, which works correctly with
URLSessionWebSocketTask.

Verified by A/B testing on iOS:
- httpAdditionalHeaders on config → immediate -1005 failure
- Same headers on URLRequest → successful connection, held for 60s+

Also includes the previous fix: store continuation before calling resume()
to prevent a race condition in the delegate callback.

Fixes #919

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: preserve WebSocket subprotocol negotiation when using URLRequest headers

When headers are provided and we create a URLRequest instead of using
the URL-based webSocketTask API, the protocols parameter was silently
dropped. Set the Sec-WebSocket-Protocol header manually to preserve
subprotocol negotiation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* style: run swift-format on URLSessionWebSocket.swift

Fix line length violation flagged by CI format check.

---------

Co... (continued)

0 of 22 new or added lines in 2 files covered. (0.0%)

6334 of 7902 relevant lines covered (80.16%)

27.55 hits per line