NodeBB / NodeBB / 22866164456

85%

master: 85%

Build Type

push

github

Committed by barisusakli

Commit Message

fix: promises in groups.leave

speed up user.delete

user.delete calls `groups.leaveAllGroups` which calls rejectMembership with 500+ groups. This function then tries to remove the user from `group:<group>:pending` and `group:<group>:invited` sets so a total for 1k sets. You can't be invited or request membership to privilege groups so filter the groups before sending to rejectMembership

clearGroupTitleIfSet function tries to remove the group title from the user. It was only skipping privilege groups and registered-users, but unverified-users & verified users weren't added to the check

Messaging.leaveRooms, make a single call to isUserInRoom and passing an array of roomIds

In user.delete, check utils.isNumber(uid) once.

Call deleteVotes/deleteChats/revokeAllSessions in Promise.all

If user is local dont call activitypub.actors.remove(), this saves a db call to `await db.isSortedSetMember('usersRemote:lastCrawled', id);`

Coverage Stats

13392 of 18326 branches covered (73.08%)

19 of 19 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

28283 of 33074 relevant lines covered (85.51%)

3331.69 hits per line