spesmilo / electrum / 5265127550746624

64%

master: 64%

Build Type

Pull #10514

CirrusCI

Committed by f321x

Commit Message

qml: rbf/cancel: fix type error

self.oldfeeRate is initialized as int in `QETxRbfFeeBumper` and
`QETxCanceller`. However QML expects it to be a string. Initializing
it as string fixes the exception. Previously this didn't happen as
`Abstract_Wallet.add_info_from_wallet_and_network()` would never
return False, so the `get_tx()` method would immediately overwrite
the self.oldfeeRate variable with a string.

```
 20.95 | D | gui.qml.qetxfinalizer | TxMonMixin.__init__
 20.95 | E | gui.qml.qeapp.Exception_Hook | exception caught by crash reporter
TypeError: unable to convert a Python 'int' object to a C++ 'QString' instance
```

Pull Request Pull Request #10514: transaction: re-raise NetworkException in add_info_from_network

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

2 existing lines in 2 files now uncovered.

24550 of 38450 relevant lines covered (63.85%)

0.64 hits per line