spesmilo / electrum / 4684925250568192

64%

master: 64%

Build Type

Pull #10514

CirrusCI

Committed by f321x

Commit Message

transaction: re-raise NetworkException in add_info_from_network

`Transaction.add_info_from_network` would swallow a `NetworkException`
even when `ignore_network_issues=False` is passed.
This causes `Transaction.add_info_from_wallet_and_network` to
incorrectly return True even if the operation failed.
If `QETxRbfFeeBumper` then incorrectly proceeds assuming the call was
successful `Abstract_Wallet.bump_fee()` would raise an `Exception("tx
missing info from network")`.
Should fix the traceback in
https://github.com/spesmilo/electrum/issues/5502#issuecomment-4021308427.

Pull Request Pull Request #10514: transaction: re-raise NetworkException in add_info_from_network

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

2 existing lines in 2 files now uncovered.

24550 of 38450 relevant lines covered (63.85%)

0.64 hits per line