22843805175
91%

Ran 09 Mar 2026 08:01AM UTC

Jobs 1

Files 224

Run time 1min

Badge

Embed ▾

Committed 09 Mar 2026 07:58AM UTC coverage: 91.494% (-0.001%) from 91.495%

Build # 22843805175

Build Type

push

github

Committed by

cuu508

Commit Message

Fix change_email_verify to preserve user's password when changing email

Previously, changing the email would reset user's password.
My reasoning for this was: changing the email is a mechanism for
handing the account's ownership to someone else. When you give
your account away, you probably do not want the account to keep
your own password, it is still *your* password.

In reality, users also change email address without changing the
account's ownership. Perhaps they're adding a "+something" to the
address, or perhaps they are migrating their email to a different
domain. In these cases resetting the password is unexpected
and confusing. Other apps do not do that. We should follow the
principle of least surprise and also not do that.

I don't think there is a security concern with the account keeping
the old password when the account *does* change ownership. The new
owner either knows the password or they do not. If they do not,
and they try to guess it, they do not have any advantage over any
random site visitor doing the same, same rate limits apply.

Run Details

8229 of 8994 relevant lines covered (91.49%)

0.91 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	22843805175.1	09 Mar 2026 08:01AM UTC	224	91.49	GitHub Action Run

healthchecks / healthchecks / 22843805175
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 22843805175

healthchecks / healthchecks / 22843805175 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 22843805175

healthchecks / healthchecks / 22843805175
91%

README BADGES
x