gsmlg-dev / elixir_caddy / dd7842039c5c30ad284913159b1fd381af53beac-PR-7

56%

main: 60%

Build Type

Pull #7

github

Committed by GSMLG-BOT

Commit Message

fix(admin-api): fix contract mismatches and harden error handling

Fixes five API contract bugs that caused CaseClauseError and BadMapError
exceptions on the startup config-push path:

- External.get_caddyfile/0: match bare map from Api.get_config/0
- External.push_initial_config/0: consume bare map from Api.adapt/1
- External.push_initial_config/0: consume %{status:} struct from Api.load/1
- External.execute_shell_command/1: guard against empty command string
- Api.load/1: guard against nil from get_config/0

Also improves error handling in Request.do_recv/3 by propagating read_body
errors and using safe Jason.decode/1 instead of decode!. Replaces direct
Logger calls with Caddy.Telemetry.log_debug to comply with Constitution
Principle II. Adds comprehensive behavioral test coverage for all scenarios.

All public API signatures remain unchanged. No new dependencies added.

Pull Request Pull Request #7: fix(admin-api): fix contract mismatches and harden error handling

Coverage Stats

10 of 18 new or added lines in 3 files covered. (55.56%)

2 existing lines in 2 files now uncovered.

769 of 1376 relevant lines covered (55.89%)

14.36 hits per line