Azure / karpenter-provider-azure / 22816614547

94%

main: 94%

Pull #1455

github

refactor: move per-machine field registry to instance package (Proposals A+C)

Move ClearPerMachineFields and ClearReadOnlyFields from batch subpackage to
the instance package (batch_field_registry.go), co-located with the template
builder. This ensures developers modifying buildAKSMachineTemplate naturally
discover the batch field classification when adding new per-NodeClaim fields.

Proposal A: Central field registry with extensive doc comments covering when
to update, design context, known gaps (offerings-related fields like Zones
live on Machine not MachineProperties), and future improvement reference
(Proposal B: type-safe config split).

Proposal C: Batch-awareness tests in the instance package that verify two
templates differing only in per-machine fields produce the same grouping
hash, and templates with different shared config produce different hashes.

Also adds BATCH comments in aksmachineinstancehelpers.go at Tags and Zones
lines, pointing to batch_field_registry.go for the field classification
checklist.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

333 of 481 new or added lines in 11 files covered. (69.23%)

59128 of 62867 relevant lines covered (94.05%)

0.96 hits per line