systemd / systemd / 22810165351
72%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 1999
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.6% (-0.03%) from 72.63%
22810165351

push

github

web-flow 
user-record: fix segfault when processing matchHostname field (#40979)

Fix a typo which causes a segfault when processing a user record
with `matchHostname` when it's an array instead of a simple string:

```
$ echo '{"userName":"crashhostarray","perMachine":[{"matchHostname":["host1","host2"],"locked":false}]}' | userdbctl -F -
Segmentation fault         (core dumped)

$ coredumpctl info
...
       Message: Process 1172301 (userdbctl) of user 1000 dumped core.

                Module libz.so.1 from rpm zlib-ng-2.3.3-1.fc43.x86_64
                Module libcrypto.so.3 from rpm openssl-3.5.4-2.fc43.x86_64
                Stack trace of thread 1172301:
                #0  0x00007fded7b3a656 __strcmp_evex (libc.so.6 + 0x159656)
                #1  0x00007fded7e95397 per_machine_hostname_match (libsystemd-shared-260.so + 0x295397)
                #2  0x00007fded7e955b5 per_machine_match (libsystemd-shared-260.so + 0x2955b5)
                #3  0x00007fded7e957c6 dispatch_per_machine (libsystemd-shared-260.so + 0x2957c6)
                #4  0x00007fded7e96c97 user_record_load (libsystemd-shared-260.so + 0x296c97)
                #5  0x000000000040572d display_user (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x572d)
                #6  0x00007fded7ea9727 dispatch_verb (libsystemd-shared-260.so + 0x2a9727)
                #7  0x000000000041077c run (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x1077c)
                #8  0x00000000004107ce main (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x107ce)
                #9  0x00007fded79e45b5 __libc_start_call_main (libc.so.6 + 0x35b5)
                #10 0x00007fded79e4668 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x3668)
                #11 0x00000000004038d5 _start (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x38d5)
                ELF object binary architecture: AMD x86-64
```

5 of 35 new or added lines in 2 files covered. (14.29%)

340 existing lines in 46 files now uncovered.

316214 of 435555 relevant lines covered (72.6%)

1144732.27 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
7
56.9
 0.62% src/shared/user-record.c
23
0.0
 src/fuzz/fuzz-user-record.c

Uncovered Existing Lines

Lines Coverage ∆ File
1
89.78
 -0.19% src/basic/compress.c
1
82.0
 -2.0% src/basic/errno-util.h
1
40.33
 -0.07% src/basic/terminal-util.c
1
58.07
 -0.06% src/core/main.c
1
66.68
 0.96% src/core/service.c
1
54.65
 -0.09% src/home/homed-manager.c
1
92.26
 -0.05% src/libsystemd/sd-journal/journal-file.c
1
77.58
 -0.19% src/network/networkd-dhcp-server.c
1
88.75
 -0.25% src/network/networkd-neighbor.c
1
83.83
 0.0% src/network/networkd-route.c
1
76.64
 -0.16% src/resolve/resolved-dns-server.c
1
79.68
 -0.06% src/resolve/resolved-dns-transaction.c
1
81.26
 -0.23% src/resolve/resolved-hook.c
1
94.97
 -0.08% src/shared/dns-rr.c
1
81.4
 -1.16% src/shared/journal-util.c
1
81.0
 -0.24% src/udev/udev-node.c
2
87.7
 -0.79% src/basic/pidref.c
2
74.72
 -0.09% src/core/cgroup.c
2
84.81
 0.06% src/network/networkd-link.c
2
67.36
 -0.69% src/resolve/resolved-llmnr.c
2
47.01
 -0.8% src/shared/watchdog.c
3
79.87
 -0.18% src/core/execute.c
3
95.29
 -3.53% src/journal/journald-rate-limit.c
3
56.92
 -0.35% src/login/logind-session.c
4
69.59
 -0.13% src/core/exec-invoke.c
4
76.64
 -0.73% src/core/timer.c
4
81.14
 -0.12% src/core/unit.c
4
76.22
 -0.31% src/journal/journald-manager.c
4
77.74
 -1.51% src/journal-remote/journal-upload-journal.c
5
81.41
 -0.21% src/libsystemd/sd-varlink/sd-varlink.c
5
69.14
 -0.28% src/network/networkd-ndisc.c
6
58.04
 -4.2% src/core/dbus-scope.c
6
78.88
 0.87% src/core/job.c
6
64.01
 -0.82% src/libsystemd/sd-journal/journal-verify.c
10
53.57
 -0.68% src/core/dbus-manager.c
11
62.69
 -0.52% src/core/socket.c
13
40.34
 -10.92% src/core/emergency-action.c
16
75.81
 -2.87% src/core/automount.c
16
80.38
 -8.86% src/journal/journald-sync.c
17
57.14
 -2.86% src/basic/confidential-virt.c
20
81.47
 0.85% src/core/manager.c
21
50.49
 -20.39% src/timesync/timesyncd.c
23
61.52
 -6.23% src/core/scope.c
33
74.74
 -3.13% src/bootctl/bootctl-install.c
34
38.07
 -19.32% src/ask-password/ask-password.c
43
75.5
 -7.05% src/core/transaction.c
Jobs
ID Job ID Ran Files Coverage
1 22810165351.1 1999
72.6
 GitHub Action Run
Source Files on build 22810165351