stacklok / toolhive / 22759908352

64%

Build Type

push

github

Committed by web-flow

Commit Message

Fix infinite reconciliation caused by PodTemplateSpec JSON comparison (#4012)

* Fix infinite reconciliation caused by PodTemplateSpec JSON comparison

When a VirtualMCPServer has a PodTemplateSpec, podTemplateSpecNeedsUpdate
compared the full JSON of the freshly-generated deployment template against
the cluster deployment template. These always differed because Kubernetes
API server adds defaulted fields (terminationGracePeriodSeconds, dnsPolicy,
restartPolicy, schedulerName, etc.) to the stored Deployment that are not
present in the controller-generated template. This caused every reconcile
to detect the deployment "needs update", update it, which triggered another
reconcile — an infinite loop.

Replace the JSON comparison with a SHA256 hash annotation approach:
- Store a hash of the raw PodTemplateSpec on the Deployment annotation
- Compare only the hash to detect actual user changes
- Handle edge cases: PodTemplateSpec added, removed, nil annotations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use deterministic JSON hashing for PodTemplateSpec annotation

Add HashRawJSON to the checksum package that unmarshals and re-marshals
JSON before hashing, ensuring consistent key ordering regardless of the
original serialization order. Replace direct sha256.Sum256 calls on raw
JSON bytes in the controller and deployment code with this new utility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add log in failed to hash error

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

21 of 25 new or added lines in 3 files covered. (84.0%)

5 existing lines in 2 files now uncovered.

47064 of 73691 relevant lines covered (63.87%)

74.97 hits per line