kubernetes-sigs / cloud-provider-azure / 22744899066
75%
master: 75%

LAST BUILD BRANCH: chengan/update-vendor-licenses
DEFAULT BRANCH: master
Ran
Jobs 1
Files 94
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 74.916% (-0.02%) from 74.931%
22744899066

push

github

web-flow 
[release-1.34]feat: implement tagsList-based Interconnect Group ID retrieval from IMDS (#10007)

* Label node with Interconnect Group ID (placeholder implementation)

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds the infrastructure/plumbing code for Interconnect Group node labeling but with a placeholder implementation that returns empty string. This allows the infrastructure to be in place and tested without breaking anything, while the actual IMDS parsing implementation can be added later when the format is finalized.

Which issue(s) this PR fixes:
N/A (New feature - infrastructure preparation)

Special notes for your reviewer:
Changes:
- pkg/consts: Add LabelInterconnectGroup constant
- pkg/provider: Add GetInterconnectGroupId method (returns empty)
- pkg/nodemanager: Add GetInterconnectGroupId to interface and integration code
- pkg/node: Implement GetInterconnectGroupId for both IMDS and ARM providers (both return empty)
- pkg/provider: Add minimal unit test

Behavior:
- GetInterconnectGroupId() always returns ("", nil)
- No label is applied to nodes
- No errors, nothing breaks
- Infrastructure is ready for future implementation

This approach allows:
1. Code review and testing of the infrastructure separately
2. Future IMDS parsing logic to be added without modifying the interface
3. Safe deployment - guaranteed not to break anything
4. No assumptions about IMDS format (no TagsList or other structures added)

Does this PR introduce a user-facing change?
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE

* Implement TagsList-based Interconnect Group ID retrieval from IMDS

This commit implements the actual IMDS parsing logic to retrieve the
Platform Interconnect Group ID from Azure instance metadata using the
tagsList field.

Implementation changes:
- Add TagNameInterconnectGroup constant for the IMDS tag name
- Add Tag struct to represent IMDS tag key-valu... (continued)

14088 of 18805 relevant lines covered (74.92%)

868.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
94
76.06
 -0.18% nodemanager/nodemanager.go
29
79.88
 1.56% provider/azure_instance_metadata.go
3
0.0
 0.0% node/nodearm.go
3
0.0
 0.0% node/node.go
3
68.95
 -0.08% provider/storage/azure_storageaccount.go
Jobs
ID Job ID Ran Files Coverage
1 22744899066.1 94
74.92
 GitHub Action Run
Source Files on build 22744899066