• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 22744998495

06 Mar 2026 01:36AM UTC coverage: 92.931%. Remained the same
22744998495

Pull #23158

github

web-flow
Merge d00f1f3d9 into f0030f5e7
Pull Request #23158: A `sync` option for `generate-lockfiles`.

10 of 11 new or added lines in 2 files covered. (90.91%)

8 existing lines in 1 file now uncovered.

90965 of 97884 relevant lines covered (92.93%)

4.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.44
/src/python/pants/backend/python/goals/lockfile.py
1
# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
2
# Licensed under the Apache License, Version 2.0 (see LICENSE).
3

4
from __future__ import annotations
12✔
5

6
import itertools
12✔
7
import os.path
12✔
8
from collections import defaultdict
12✔
9
from dataclasses import dataclass
12✔
10
from operator import itemgetter
12✔
11

12
from pants.backend.python.subsystems.python_tool_base import PythonToolBase
12✔
13
from pants.backend.python.subsystems.setup import PythonSetup
12✔
14
from pants.backend.python.target_types import (
12✔
15
    PythonRequirementFindLinksField,
16
    PythonRequirementResolveField,
17
    PythonRequirementsField,
18
)
19
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
12✔
20
from pants.backend.python.util_rules.lockfile_diff import _generate_python_lockfile_diff
12✔
21
from pants.backend.python.util_rules.lockfile_metadata import PythonLockfileMetadata
12✔
22
from pants.backend.python.util_rules.pex import (
12✔
23
    CompletePlatforms,
24
    digest_complete_platform_addresses,
25
    find_interpreter,
26
)
27
from pants.backend.python.util_rules.pex_cli import PexCliProcess, maybe_log_pex_stderr
12✔
28
from pants.backend.python.util_rules.pex_environment import PexSubsystem
12✔
29
from pants.backend.python.util_rules.pex_requirements import (
12✔
30
    PexRequirements,
31
    ResolvePexConfig,
32
    ResolvePexConfigRequest,
33
    determine_resolve_pex_config,
34
)
35
from pants.base.glob_match_error_behavior import GlobMatchErrorBehavior
12✔
36
from pants.core.goals.generate_lockfiles import (
12✔
37
    DEFAULT_TOOL_LOCKFILE,
38
    GenerateLockfile,
39
    GenerateLockfileResult,
40
    GenerateLockfilesSubsystem,
41
    KnownUserResolveNames,
42
    KnownUserResolveNamesRequest,
43
    RequestedUserResolveNames,
44
    UserGenerateLockfiles,
45
    WrappedGenerateLockfile,
46
)
47
from pants.core.goals.resolves import ExportableTool
12✔
48
from pants.core.util_rules.lockfile_metadata import calculate_invalidation_digest
12✔
49
from pants.engine.addresses import UnparsedAddressInputs
12✔
50
from pants.engine.fs import (
12✔
51
    CreateDigest,
52
    Digest,
53
    FileContent,
54
    GlobExpansionConjunction,
55
    MergeDigests,
56
    PathGlobs,
57
)
58
from pants.engine.internals.native_engine import EMPTY_DIGEST
12✔
59
from pants.engine.internals.synthetic_targets import SyntheticAddressMaps, SyntheticTargetsRequest
12✔
60
from pants.engine.internals.target_adaptor import TargetAdaptor
12✔
61
from pants.engine.intrinsics import (
12✔
62
    create_digest,
63
    get_digest_contents,
64
    merge_digests,
65
    path_globs_to_digest,
66
)
67
from pants.engine.process import ProcessCacheScope, execute_process_or_raise
12✔
68
from pants.engine.rules import collect_rules, implicitly, rule
12✔
69
from pants.engine.target import AllTargets
12✔
70
from pants.engine.unions import UnionMembership, UnionRule
12✔
71
from pants.option.subsystem import _construct_subsystem
12✔
72
from pants.util.docutil import bin_name
12✔
73
from pants.util.logging import LogLevel
12✔
74
from pants.util.ordered_set import FrozenOrderedSet
12✔
75
from pants.util.pip_requirement import PipRequirement
12✔
76

77

78
@dataclass(frozen=True)
12✔
79
class GeneratePythonLockfile(GenerateLockfile):
12✔
80
    requirements: FrozenOrderedSet[str]
12✔
81
    find_links: FrozenOrderedSet[str]
12✔
82
    interpreter_constraints: InterpreterConstraints
12✔
83
    lock_style: str
12✔
84
    complete_platforms: tuple[str, ...]
12✔
85

86
    @property
12✔
87
    def requirements_hex_digest(self) -> str:
12✔
88
        """Produces a hex digest of the requirements input for this lockfile."""
89
        return calculate_invalidation_digest(self.requirements)
×
90

91

92
@rule
12✔
93
async def wrap_python_lockfile_request(request: GeneratePythonLockfile) -> WrappedGenerateLockfile:
12✔
94
    return WrappedGenerateLockfile(request)
×
95

96

97
@dataclass(frozen=True)
12✔
98
class _PipArgsAndConstraintsSetup:
12✔
99
    resolve_config: ResolvePexConfig
12✔
100
    args: tuple[str, ...]
12✔
101
    digest: Digest
12✔
102

103

104
async def _setup_pip_args_and_constraints_file(resolve_name: str) -> _PipArgsAndConstraintsSetup:
12✔
105
    resolve_config = await determine_resolve_pex_config(
2✔
106
        ResolvePexConfigRequest(resolve_name), **implicitly()
107
    )
108

109
    args = list(resolve_config.pex_args())
2✔
110
    digests: list[Digest] = []
2✔
111

112
    if resolve_config.constraints_file:
2✔
113
        args.append(f"--constraints={resolve_config.constraints_file.path}")
1✔
114
        digests.append(resolve_config.constraints_file.digest)
1✔
115

116
    input_digest = await merge_digests(MergeDigests(digests))
2✔
117
    return _PipArgsAndConstraintsSetup(resolve_config, tuple(args), input_digest)
2✔
118

119

120
@rule(desc="Generate Python lockfile", level=LogLevel.DEBUG)
12✔
121
async def generate_lockfile(
12✔
122
    req: GeneratePythonLockfile,
123
    generate_lockfiles_subsystem: GenerateLockfilesSubsystem,
124
    python_setup: PythonSetup,
125
    pex_subsystem: PexSubsystem,
126
) -> GenerateLockfileResult:
127
    if not req.requirements:
2✔
128
        raise ValueError(
1✔
129
            f"Cannot generate lockfile with no requirements. Please add some requirements to {req.resolve_name}."
130
        )
131

132
    pip_args_setup = await _setup_pip_args_and_constraints_file(req.resolve_name)
2✔
133
    header_delimiter = "//"
2✔
134

135
    python = await find_interpreter(req.interpreter_constraints, **implicitly())
2✔
136

137
    # Resolve complete platform targets if specified
138
    complete_platforms: CompletePlatforms | None = None
2✔
139
    if req.complete_platforms:
2✔
140
        # Resolve target addresses to get platform JSON files
141
        complete_platforms = await digest_complete_platform_addresses(
×
142
            UnparsedAddressInputs(
143
                req.complete_platforms,
144
                owning_address=None,
145
                description_of_origin=f"the `[python].resolves_to_complete_platforms` for resolve `{req.resolve_name}`",
146
            )
147
        )
148

149
    # Add complete platforms if specified, otherwise use default target systems for universal locks
150
    if complete_platforms:
2✔
151
        target_system_args = tuple(
×
152
            f"--complete-platform={platform}" for platform in complete_platforms
153
        )
154
    elif req.lock_style == "universal":
2✔
155
        # PEX files currently only run on Linux and Mac machines; so we hard code this
156
        # limit on lock universality to avoid issues locking due to irrelevant
157
        # Windows-only dependency issues. See this Pex issue that originated from a
158
        # Pants user issue presented in Slack:
159
        #   https://github.com/pex-tool/pex/issues/1821
160
        #
161
        # Note: --target-system only applies to universal locks. For other lock styles
162
        # (strict, sources) without complete platforms, we don't specify platform args
163
        # and PEX will lock for the current platform only.
164
        target_system_args = (
2✔
165
            "--target-system",
166
            "linux",
167
            "--target-system",
168
            "mac",
169
        )
170
    else:
171
        # For non-universal lock styles without complete platforms, don't specify
172
        # platform arguments - PEX will lock for the current platform only
173
        target_system_args = ()
×
174

175
    if generate_lockfiles_subsystem.sync:
2✔
NEW
176
        existing_lockfile_digest = await path_globs_to_digest(
×
177
            PathGlobs(
178
                globs=(req.lockfile_dest,),
179
                # We ignore errors, since the lockfile may not exist.
180
                glob_match_error_behavior=GlobMatchErrorBehavior.ignore,
181
                conjunction=GlobExpansionConjunction.any_match,
182
            )
183
        )
184
    else:
185
        existing_lockfile_digest = EMPTY_DIGEST
2✔
186

187
    output_flag = "--lock" if generate_lockfiles_subsystem.sync else "--output"
2✔
188
    result = await execute_process_or_raise(
2✔
189
        **implicitly(
190
            PexCliProcess(
191
                subcommand=("lock", "sync" if generate_lockfiles_subsystem.sync else "create"),
192
                extra_args=(
193
                    f"{output_flag}={req.lockfile_dest}",
194
                    f"--style={req.lock_style}",
195
                    "--pip-version",
196
                    python_setup.pip_version,
197
                    "--resolver-version",
198
                    "pip-2020-resolver",
199
                    "--preserve-pip-download-log",
200
                    "pex-pip-download.log",
201
                    *target_system_args,
202
                    # This makes diffs more readable when lockfiles change.
203
                    "--indent=2",
204
                    f"--python-path={python.path}",
205
                    *(f"--find-links={link}" for link in req.find_links),
206
                    *pip_args_setup.args,
207
                    # When complete platforms are specified, don't pass interpreter constraints.
208
                    # The complete platforms already define Python versions and platforms.
209
                    # Passing both causes PEX to generate duplicate locked_requirements entries
210
                    # when the local platform matches a complete platform.
211
                    # TODO(#9560): Consider validating that these platforms are valid with the
212
                    #  interpreter constraints.
213
                    *(
214
                        req.interpreter_constraints.generate_pex_arg_list()
215
                        if not complete_platforms
216
                        else ()
217
                    ),
218
                    *(
219
                        f"--override={override}"
220
                        for override in pip_args_setup.resolve_config.overrides
221
                    ),
222
                    *req.requirements,
223
                ),
224
                additional_input_digest=await merge_digests(
225
                    MergeDigests(
226
                        [existing_lockfile_digest, pip_args_setup.digest]
227
                        + ([complete_platforms.digest] if complete_platforms else [])
228
                    )
229
                ),
230
                output_files=(req.lockfile_dest,),
231
                description=f"Generate lockfile for {req.resolve_name}",
232
                # Instead of caching lockfile generation with LMDB, we instead use the invalidation
233
                # scheme from `lockfile_metadata.py` to check for stale/invalid lockfiles. This is
234
                # necessary so that our invalidation is resilient to deleting LMDB or running on a
235
                # new machine.
236
                #
237
                # We disable caching with LMDB so that when you generate a lockfile, you always get
238
                # the most up-to-date snapshot of the world. This is generally desirable and also
239
                # necessary to avoid an awkward edge case where different developers generate
240
                # different lockfiles even when generating at the same time. See
241
                # https://github.com/pantsbuild/pants/issues/12591.
242
                cache_scope=ProcessCacheScope.PER_SESSION,
243
            )
244
        )
245
    )
246
    maybe_log_pex_stderr(result.stderr, pex_subsystem.verbosity)
2✔
247

248
    metadata = PythonLockfileMetadata.new(
2✔
249
        valid_for_interpreter_constraints=req.interpreter_constraints,
250
        requirements={
251
            PipRequirement.parse(
252
                i,
253
                description_of_origin=f"the lockfile {req.lockfile_dest} for the resolve {req.resolve_name}",
254
            )
255
            for i in req.requirements
256
        },
257
        manylinux=pip_args_setup.resolve_config.manylinux,
258
        requirement_constraints=(
259
            set(pip_args_setup.resolve_config.constraints_file.constraints)
260
            if pip_args_setup.resolve_config.constraints_file
261
            else set()
262
        ),
263
        only_binary=set(pip_args_setup.resolve_config.only_binary),
264
        no_binary=set(pip_args_setup.resolve_config.no_binary),
265
        excludes=set(pip_args_setup.resolve_config.excludes),
266
        overrides=set(pip_args_setup.resolve_config.overrides),
267
        sources=set(pip_args_setup.resolve_config.sources),
268
        lock_style=req.lock_style,
269
        complete_platforms=req.complete_platforms,
270
    )
271
    regenerate_command = (
2✔
272
        generate_lockfiles_subsystem.custom_command
273
        or f"{bin_name()} generate-lockfiles --resolve={req.resolve_name}"
274
    )
275
    if python_setup.separate_lockfile_metadata_file:
2✔
276
        descr = f"This lockfile was generated by Pants. To regenerate, run: {regenerate_command}"
1✔
277
        metadata_digest = await create_digest(
1✔
278
            CreateDigest(
279
                [
280
                    FileContent(
281
                        PythonLockfileMetadata.metadata_location_for_lockfile(req.lockfile_dest),
282
                        metadata.to_json(with_description=descr).encode(),
283
                    ),
284
                ]
285
            )
286
        )
287
        final_lockfile_digest = await merge_digests(
1✔
288
            MergeDigests([metadata_digest, result.output_digest])
289
        )
290
    else:
291
        initial_lockfile_digest_contents = await get_digest_contents(result.output_digest)
2✔
292
        lockfile_with_header = metadata.add_header_to_lockfile(
2✔
293
            initial_lockfile_digest_contents[0].content,
294
            regenerate_command=regenerate_command,
295
            delimeter=header_delimiter,
296
        )
297
        final_lockfile_digest = await create_digest(
2✔
298
            CreateDigest(
299
                [
300
                    FileContent(req.lockfile_dest, lockfile_with_header),
301
                ]
302
            )
303
        )
304

305
    if req.diff:
2✔
306
        diff = await _generate_python_lockfile_diff(
×
307
            final_lockfile_digest, req.resolve_name, req.lockfile_dest
308
        )
309
    else:
310
        diff = None
2✔
311

312
    return GenerateLockfileResult(final_lockfile_digest, req.resolve_name, req.lockfile_dest, diff)
2✔
313

314

315
class RequestedPythonUserResolveNames(RequestedUserResolveNames):
12✔
316
    pass
12✔
317

318

319
class KnownPythonUserResolveNamesRequest(KnownUserResolveNamesRequest):
12✔
320
    pass
12✔
321

322

323
@rule
12✔
324
async def determine_python_user_resolves(
12✔
325
    _: KnownPythonUserResolveNamesRequest,
326
    python_setup: PythonSetup,
327
    union_membership: UnionMembership,
328
) -> KnownUserResolveNames:
329
    """Find all know Python resolves, from both user-created resolves and internal tools."""
330
    python_tool_resolves = ExportableTool.filter_for_subclasses(union_membership, PythonToolBase)
1✔
331

332
    tools_using_default_resolve = [
1✔
333
        resolve_name
334
        for resolve_name, subsystem_cls in python_tool_resolves.items()
335
        if (await _construct_subsystem(subsystem_cls)).install_from_resolve is None
336
    ]
337

338
    return KnownUserResolveNames(
1✔
339
        names=(
340
            *python_setup.resolves.keys(),
341
            *tools_using_default_resolve,
342
        ),  # the order of the keys doesn't matter since shadowing is done in `setup_user_lockfile_requests`
343
        option_name="[python].resolves",
344
        requested_resolve_names_cls=RequestedPythonUserResolveNames,
345
    )
346

347

348
@rule
12✔
349
async def setup_user_lockfile_requests(
12✔
350
    requested: RequestedPythonUserResolveNames,
351
    all_targets: AllTargets,
352
    python_setup: PythonSetup,
353
    union_membership: UnionMembership,
354
) -> UserGenerateLockfiles:
355
    """Transform the names of resolves requested into the `GeneratePythonLockfile` request object.
356

357
    Shadowing is done here by only checking internal resolves if the resolve is not a user-created
358
    resolve.
359
    """
360
    if not (python_setup.enable_resolves and python_setup.resolves_generate_lockfiles):
1✔
361
        return UserGenerateLockfiles()
×
362

363
    resolve_to_requirements_fields = defaultdict(set)
1✔
364
    find_links: set[str] = set()
1✔
365
    for tgt in all_targets:
1✔
366
        if not tgt.has_fields((PythonRequirementResolveField, PythonRequirementsField)):
1✔
367
            continue
×
368
        resolve = tgt[PythonRequirementResolveField].normalized_value(python_setup)
1✔
369
        resolve_to_requirements_fields[resolve].add(tgt[PythonRequirementsField])
1✔
370
        find_links.update(tgt[PythonRequirementFindLinksField].value or ())
1✔
371

372
    tools = ExportableTool.filter_for_subclasses(union_membership, PythonToolBase)
1✔
373

374
    out = set()
1✔
375
    for resolve in requested:
1✔
376
        if resolve in python_setup.resolves:
1✔
377
            out.add(
1✔
378
                GeneratePythonLockfile(
379
                    requirements=PexRequirements.req_strings_from_requirement_fields(
380
                        resolve_to_requirements_fields[resolve]
381
                    ),
382
                    find_links=FrozenOrderedSet(find_links),
383
                    interpreter_constraints=InterpreterConstraints(
384
                        python_setup.resolves_to_interpreter_constraints.get(
385
                            resolve, python_setup.interpreter_constraints
386
                        )
387
                    ),
388
                    resolve_name=resolve,
389
                    lockfile_dest=python_setup.resolves[resolve],
390
                    diff=False,
391
                    lock_style=python_setup.resolves_to_lock_style().get(resolve, "universal"),
392
                    complete_platforms=tuple(
393
                        python_setup.resolves_to_complete_platforms().get(resolve, [])
394
                    ),
395
                )
396
            )
397
        else:
398
            tool_cls: type[PythonToolBase] = tools[resolve]
×
399
            tool = await _construct_subsystem(tool_cls)
×
400

401
            # TODO: we shouldn't be managing default ICs in lockfile identification.
402
            #   We should find a better place to do this or a better way to default
403
            if tool.register_interpreter_constraints:
×
404
                ic = tool.interpreter_constraints
×
405
            else:
406
                ic = InterpreterConstraints(tool.default_interpreter_constraints)
×
407

408
            out.add(
×
409
                GeneratePythonLockfile(
410
                    requirements=FrozenOrderedSet(sorted(tool.requirements)),
411
                    find_links=FrozenOrderedSet(find_links),
412
                    interpreter_constraints=ic,
413
                    resolve_name=resolve,
414
                    lockfile_dest=DEFAULT_TOOL_LOCKFILE,
415
                    diff=False,
416
                    lock_style="universal",  # Tools always use universal style
417
                    complete_platforms=(),  # Tools don't use complete platforms
418
                )
419
            )
420

421
    return UserGenerateLockfiles(out)
1✔
422

423

424
@dataclass(frozen=True)
12✔
425
class PythonSyntheticLockfileTargetsRequest(SyntheticTargetsRequest):
12✔
426
    """Register the type used to create synthetic targets for Python lockfiles.
427

428
    As the paths for all lockfiles are known up-front, we set the `path` field to
429
    `SyntheticTargetsRequest.SINGLE_REQUEST_FOR_ALL_TARGETS` so that we get a single request for all
430
    our synthetic targets rather than one request per directory.
431
    """
432

433
    path: str = SyntheticTargetsRequest.SINGLE_REQUEST_FOR_ALL_TARGETS
12✔
434

435

436
def synthetic_lockfile_target_name(resolve: str) -> str:
12✔
437
    return f"_{resolve}_lockfile"
3✔
438

439

440
@rule
12✔
441
async def python_lockfile_synthetic_targets(
12✔
442
    request: PythonSyntheticLockfileTargetsRequest,
443
    python_setup: PythonSetup,
444
) -> SyntheticAddressMaps:
445
    if not python_setup.enable_synthetic_lockfiles:
11✔
446
        return SyntheticAddressMaps()
11✔
447

448
    resolves = [
3✔
449
        (os.path.dirname(lockfile), os.path.basename(lockfile), name)
450
        for name, lockfile in python_setup.resolves.items()
451
    ]
452

453
    return SyntheticAddressMaps.for_targets_request(
3✔
454
        request,
455
        [
456
            (
457
                os.path.join(spec_path, "BUILD.python-lockfiles"),
458
                tuple(
459
                    TargetAdaptor(
460
                        "_lockfiles",
461
                        name=synthetic_lockfile_target_name(name),
462
                        sources=(lockfile,),
463
                        __description_of_origin__=f"the [python].resolves option {name!r}",
464
                    )
465
                    for _, lockfile, name in lockfiles
466
                ),
467
            )
468
            for spec_path, lockfiles in itertools.groupby(sorted(resolves), key=itemgetter(0))
469
        ],
470
    )
471

472

473
def rules():
12✔
474
    return (
11✔
475
        *collect_rules(),
476
        UnionRule(GenerateLockfile, GeneratePythonLockfile),
477
        UnionRule(KnownUserResolveNamesRequest, KnownPythonUserResolveNamesRequest),
478
        UnionRule(RequestedUserResolveNames, RequestedPythonUserResolveNames),
479
        UnionRule(SyntheticTargetsRequest, PythonSyntheticLockfileTargetsRequest),
480
    )
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc