kubevirt / hyperconverged-cluster-operator / 22721296982

79%

push

github

CNV-78904: Add webhooks for v1 + conversion webhook (#4063)

* create v1 mutate webhook as a copy of v1beta1 one

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* create v1 validating webhook as a copy of v1beta1 one

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Register v1 mutating and validating webhooks

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Deploy the new webhooks

Add the new v1 mutating and validating webhooks to the deployment
manifests (the CSVs manifest for OLM deployment, and the
deploy/webhooks.yaml file, to be used by the the hack/deploy.sh
script.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add and register the conversion webhook

The conversion webhook is built automatically by the operator-runtime,
based on the `Hub` and `conversion.Convertible` interfaces we already
implemented for the HyperConverged type.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* add conversion webhook configuration to the CRD

Added a new controller to the webhook pod, to watch the HCO CRD, and to
add the conversion webhook configurations to the CRD spec.

In plain K8s or when deploying with OLM v1, the caBundle field is
injected to the CRD, as result of an annotation.

For OLM v0 installation, the controller takes the caBundle from the
secret, instead of using caBundle injection annotation.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Add a functional test for conversion

Add a very naive e2e test to read the HyperConverged CR in v1 format.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* fix comment from previous PR

Fix this comment: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/4046#discussion_r2871449465

disable the specific `receiver-naming` linter rule (from the revive
linter)

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

557 of 662 new or added lines in 8 files covered. (84.14%)

9294 of 11760 relevant lines covered (79.03%)

1.95 hits per line