UI5 / webcomponents-react / 22718865900

85%

Build Type

push

github

Committed by web-flow

Commit Message

feat(AnalyticalTable): add `allVisibleRowsSelected` to `onRowSelect` &  improve select behavior (#8224)

Changes in this PR:
- adds `allVisibleRowsSelected` to the `onRowSelect` event detail. When
all visible rows in a filtered table (all not filtered-out rows) are
selected, this property is `true`.
- refactors how the `onRowSelect` event is fired. Now, the original
event is persisted on the mutable table instance and only enriched and
fired after the respective table state is finalized.
- forks the `useRowSelect` react-table hook
  - Early exit when `selectionMode` is 'None'
- Skips `selectedFlatRows` computation, `isAllRowsSelected` checks, and
`prepareRow` overhead when selection is disabled
  - `isAllRowsSelected` computation is memoized
  - Uses stable noop references when disabled
- Fixes select-all indeterminate state considering filtered-out rows
(now only visible rows are considered)
- Fixes indeterminate state of select-all checkbox when the table is
filtered.
- `useIndeterminateRowSelection`: parent row is now also included in
`selectedRowIds` when all sub rows are selected
- improves `stateReducer` type

Run Details

3476 of 4433 branches covered (78.41%)

Branch coverage included in aggregate %.

183 of 213 new or added lines in 8 files covered. (85.92%)

2 existing lines in 1 file now uncovered.

6511 of 7316 relevant lines covered (89.0%)

112211.13 hits per line