NVIDIA / holodeck / 22715737674

50%

push

github

feat(provisioner): integrate custom templates into dependency resolver (#565) (#706)

* feat(provisioner): integrate custom templates into dependency resolver (#565)

Add custom template support to the DependencyResolver with five execution
phases (pre-install, post-runtime, post-toolkit, post-kubernetes, post-install).
Support inline, file, and URL sources with SHA256 checksum verification.

- Add addCustomTemplates/executeCustomTemplate methods to DependencyResolver
- Add SetBaseDir for resolving relative file paths
- Add custom template validation in Dryrun (phase, source checks)
- Add comprehensive tests for resolver, dryrun, and YAML integration
- Add user documentation in docs/guides/custom-templates.md

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix(provisioner): address lint and CI findings on PR #706

- Fix unchecked resp.Body.Close() with deferred error discard
- Run gofmt on dryrun.go
- Fix gosec G304: add filepath.Clean() before os.ReadFile
- Fix gosec G306: use 0600 permissions for test file writes
- Fix MD013: wrap doc lines to under 120 characters

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix(docs): wrap prose lines to 80 chars for MD013 compliance

Wrap all non-code-block lines in custom-templates.md to stay under the
80-character line length limit enforced by markdownlint MD013.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* refactor: delegate to templates package, remove duplicated code

Replace duplicated fetchURL, verifyChecksum, executeCustomTemplate with
calls to templates.LoadCustomTemplate and NewCustomTemplateExecutor.
Replace validateCustomTemplates with templates.ValidateTemplateInputs.
Fix dryrun test checksum to match 64-char hex format required by the
merged validator.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

50 of 56 new or added lines in 2 files covered. (89.29%)

2847 of 5712 relevant lines covered (49.84%)

0.56 hits per line