NVIDIA / holodeck / 22713829380

50%

push

github

feat(validate): add custom template input validation (#565) (#703)

* feat(validate): add custom template input validation (#565)

Validates template name, phase, source exclusivity, URL scheme (HTTPS
only), file path safety (including path traversal), checksum format
(sha256), and duplicate names.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix(validate): add env var key validation and fix path traversal check (#565)

Address review feedback on PR #703:
- R1: Validate env var keys against [a-zA-Z_][a-zA-Z0-9_]* to prevent
  command injection via export statements in the executor
- R2: Check for ".." as a path component (split on "/") instead of
  substring match, allowing legitimate filenames like "foo..bar.sh"

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

60 of 64 new or added lines in 1 file covered. (93.75%)

2717 of 5551 relevant lines covered (48.95%)

0.55 hits per line