NVIDIA / holodeck / 22713298249

50%

main: 50%

push

github

refactor(provisioner): use Task 1/2 loader, executor, and validator (#565)

Address architecture review feedback on PR #706:
- B1/B2: Fix shell injection in env var export by delegating to Task 2's
  CustomTemplateExecutor (which sanitizes env keys and values)
- R1: Remove duplicated fetchURL, verifyChecksum, executeCustomTemplate;
  use templates.LoadCustomTemplate() and NewCustomTemplateExecutor()
- R2: Inherit Task 2's 10MB response size limit for URL sources
- R3: Fix template name interpolation in shell strings via executor
- R4: Remove duplicated validPhases map; use templates.ValidateTemplateInputs()
- N1: Fix docs to say HTTPS is required (not just recommended)
- N2: Use real 64-char hex digest in docs checksum example

Cherry-picks Task 1 (validate.go) and Task 2 (custom.go) into this branch
for integration.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

127 of 155 new or added lines in 4 files covered. (81.94%)

2828 of 5691 relevant lines covered (49.69%)

0.56 hits per line