source-academy / frontend / 22710663203

41%

Build Type

push

github

Committed by web-flow

Commit Message

Option for "show all frames created" vs "show current frames only" (#3592)

* Added the removeDeadFrames feature
Only dead frames disappear as of right now, for function objects and the rest, work to be done

Animations : will be done by Keying!

* Added the functionality for toggle of dead vs ONLY live for
	function closure objects
	Generic Arrow
	Text (recursively automated)
	Arrays and hence pairs as well

* Fix : Removed gaps
Finally processed the logic by recomputing the envTree for the specific step when the toggle is on

* Fix : CI format errors and made it from checkbox -> onClick button!

* Fix : Toggle -> One time cleanup

* Changed from Hide -> Clear and the icon

* Fixed the following errors and implemented suggestions
1. Fixed the snapshot and lint erros
2. Added the disable feature (as suggested by @sayomaki) where to suggest that its CLEAR and not HIDE, we disable after pressing once!!
3. Changed all instances of hide to clear in our current implementation!

* Fixed tsc error

* Fixed the sentry bot suggestion

* Fixed the error where the frames WERE not moving due to the Layout team's invariant!
Now the frames do move by violating their invariant ONLY if the Clear mode is ON

* revert type changes

---------

Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>
Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Co-authored-by: sayomaki <sayomayomaki@gmail.com>

Run Details

2181 of 6305 branches covered (34.59%)

Branch coverage included in aggregate %.

12 of 51 new or added lines in 8 files covered. (23.53%)

1 existing line in 1 file now uncovered.

5385 of 12201 relevant lines covered (44.14%)

27.94 hits per line