Slach / clickhouse-dump / 22706047093

77%

push

github

fix(ftp): close dumper storage connections to prevent FTP pool exhaustion

The FTP storage connection pool was never closed after dump completed,
causing vsftpd to hit its connection limit when the restore command
tried to open new connections. This caused List/ReadDir calls to hang
and time out, resulting in empty file lists and silent restore failures
(database not found after restore).

Fixes:
- Add Dumper.Close() method and defer it in RunDumper so FTP connections
  are released before restore starts
- Increase FTP Timeout from 10s to 60s for slow CI environments

Diagnostics improvements:
- Enable DEBUG=1 + TESTCONTAINERS_RYUK_DISABLED=true in CI workflow
- Add -timeout 30m to prevent premature test runner cancellation
- Log restoreArgs before app.Run (was logged after)
- Log SHOW DATABASES output after restore for post-mortem analysis
- Log all files found by List() in Restore() with WARNING when zero
  database SQL files are discovered

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

12 of 17 new or added lines in 4 files covered. (70.59%)

1648 of 2153 relevant lines covered (76.54%)

151.91 hits per line