stacklok / toolhive / 22688788227

64%

Build Type

push

github

Committed by web-flow

Commit Message

Fix MCP server tests and remove macos-latest from unit test matrix (#4002)

* Fix MCP server tests to not require container runtime

The MCP server unit tests called New() directly, which internally calls
workloads.NewManager() to detect a container runtime. This caused tests
to fail on macOS GitHub Actions runners where Docker is not pre-installed
(unlike ubuntu-latest runners which have Docker by default).

Extract newServerWithHandler from New() to allow injecting a pre-built
handler. Tests now use mock dependencies via a newTestServer helper,
making them portable across all environments without relying on ambient
infrastructure.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Use real runtime on non-darwin in MCP server tests

On macOS (darwin) a container runtime may not be present, so tests use
mock dependencies. On Linux (and other platforms) the real New()
constructor is used, exercising the full stack with an actual runtime.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Use real runtime on non-darwin in MCP server tests

On macOS (darwin) a container runtime may not be present, so tests use
mock dependencies. On Linux (and other platforms) the real New()
constructor is used, exercising the full stack with an actual runtime.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Use real runtime on non-darwin in MCP server tests

On macOS (darwin) a container runtime may not be present, so tests use
mock dependencies. On Linux (and other platforms) the real New()
constructor is used, exercising the full stack with an actual runtime.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Use real runtime on non-darwin in MCP server tests

On macOS (darwin) a container runtime may not be present, so tests use
mock dependencies. On Linux (and other platforms) the real New()
constructor is used, exercising the full stack with an actual runtime.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

... (continued)

Run Details

6 of 8 new or added lines in 1 file covered. (75.0%)

10 existing lines in 3 files now uncovered.

46725 of 73216 relevant lines covered (63.82%)

76.04 hits per line