macbre / sql-metadata / 22687819175

100%

push

github

Fix infinite loop in Parser.with_names for malformed WITH statements (#605)

Resolves #556.

The parser would hang indefinitely when encountering malformed SQL with
consecutive AS keywords in WITH clauses (e.g., "WITH a AS (...) AS g").

The issue was in the with_names property loop: after processing a WITH
clause, if the next token was another AS keyword (invalid syntax), the
parser would not advance the token, causing an infinite loop.

This fix:
- Detects malformed SQL with consecutive AS keywords after WITH queries
- Raises ValueError("This query is wrong") instead of hanging
- Ensures the token always advances to prevent infinite loops
- Adds test case to verify the fix

Co-authored-by: Claude <noreply@anthropic.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

898 of 898 relevant lines covered (100.0%)

1.0 hits per line