pomerium / pomerium / 22687055219

46%

Build Type

push

github

Committed by web-flow

Commit Message

ssh: refactor StreamHandler state management (#6166)

This refactors some of the state management in `ssh.StreamHandler` to
fix potential data races between `StreamHandler.Run()` and
`StreamHandler.ServeChannel()`.

Instead of keeping state as a field in StreamHandler itself, it is kept
local to the `Run` loop. Methods which previously accessed the state
field now accept the state as an argument instead and were converted to
free functions if possible.

Operations outside of the `Run` loop which need to read the state
(currently, creating internal channels from ServeChannel, and requesting
handoff) now interact with the `Run` loop via new channels specifically
for those requests. The `Run` loop can then reply with a _copy_ of the
state and/or other needed info, or an error (if the request can fail).

Additionally, the username+hostname fields which used to be in the
stream state as individual fields were pulled out into a separate type
`api.UserRequest`. This struct holds a username and hostname, and is
only modifiable from an Update method. It encapsulates the validation
logic for username and hostname updates and should be less error-prone
to use.

Run Details

265 of 298 new or added lines in 5 files covered. (88.93%)

8 existing lines in 3 files now uncovered.

34067 of 75752 relevant lines covered (44.97%)

115.88 hits per line