AAEmu / AAEmu / 22683232304

5%

Build Type

push

github

Committed by web-flow

Commit Message

test(managers): expand unit test coverage for Id, Doodad, Character a… (#1376)

* test(managers): expand unit test coverage for Id, Doodad, Character and World managers

Add comprehensive unit tests using TheoryData for parameterized testing,
Moq for dependency isolation, and organized test regions. New test files:
- CharacterManagerTests.cs with 41 test cases
- WorldManagerTests.cs with 66 test cases

Expanded coverage in existing files:
- IdManagerTests: parameterized tests for GetNextId, ReleaseId
- DoodadManagerTests: tests for Exist, GetTemplate, GetFunc methods
- TaskManagerTests: scheduling, cancellation and task ID tests
- ItemManagerTests, QuestManagerTests, SkillManagerTests: additional edge cases

* fix(tests): correct TimeSinceStart_ReturnsTimeSpanSinceStart test logic

The test was failing due to incorrect assumptions about GameService.StartTime
initialization timing. StartTime is initialized on first class load, not
when the test runs, causing failures when other tests load the class first.

Changed the test to verify TimeSinceStart consistency with DateTime.UtcNow
- StartTime instead of comparing against an arbitrary beforeTime value.

* test: remove 16 skipped placeholder tests

Remove empty skipped tests from ItemManagerTests (12) and
CharacterManagerTests (4) that required DI singleton initialization,
database connections, or static singletons without implementation.

* fix(tests): resolve NullReferenceException in WorldInstance.CleanupInstance()

- Add null check for SpawnManager in CleanupInstance() to prevent
  NullReferenceException when finalizer runs during test execution
- Configure xUnit v3 Testing Platform support in UnitTests.csproj

The SpawnManager property could be null when WorldInstance is garbage
collected in tests, causing a fatal error despite all tests passing.

* test: remove unused expectedFirstId parameter from IdManagerTests

Run Details

2873 of 2915 new or added lines in 10 files covered. (98.56%)

2 existing lines in 2 files now uncovered.

7298 of 67597 relevant lines covered (10.8%)

0.11 hits per line