stacklok / toolhive / 22676557261

64%

Build Type

push

github

Committed by web-flow

Commit Message

Make SessionAffinity configurable via CRD field (#3994)

PR #3986 hardcoded SessionAffinity: ClientIP on all operator-created
Services. Review feedback identified this should be configurable:
stateless MCP servers don't need stickiness and external load balancers
may conflict.

Add a sessionAffinity field (enum: ClientIP/None, default: ClientIP) to
MCPServerSpec, MCPRemoteProxySpec, and VirtualMCPServerSpec. Wire the
field through service creation and drift detection in all three
controllers.

Also fix a pre-existing bug in the MCPServer controller where the
service update path did not copy Labels/Annotations, which could cause
infinite reconciliation when those fields drifted.

EmbeddingServer is intentionally excluded — embedding servers are
stateless inference endpoints, not MCP protocol services.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run Details

36 of 38 new or added lines in 5 files covered. (94.74%)

15 existing lines in 5 files now uncovered.

46619 of 73103 relevant lines covered (63.77%)

74.09 hits per line