Chia-Network / chia-blockchain / 22671361651

91%

Build Type

push

github

Committed by web-flow

Commit Message

Add missing type annotations and remove 10 mypy exclusions (#20582)

* Add missing type annotations and remove 10 mypy exclusions

Add return type annotations, parameter types, and generic type
parameters to 10 modules that had trivial mypy strict-mode violations
(1-2 errors each). Remove them from mypy-exclusions.txt so they are
now covered by strict type checking.

Modules fixed:
- chia.cmds.start_funcs (Popen generic param)
- chia.wallet.wallet_pool_store (classmethod return type)
- installhelper (return type)
- chia._tests.blockchain.blockchain_test_utils (return type)
- chia._tests.core.test_daemon_rpc (param + return types)
- chia._tests.core.test_filter (param + return types)
- chia._tests.pools.test_pool_config (param + return types)
- chia._tests.core.custom_types.test_coin (return types)
- chia._tests.core.util.test_lru_cache (return type + var annotation)
- chia._tests.core.util.test_significant_bits (return types)

Also fixes int-to-uint32 arg-type errors in test_wallet_pool_store.py
that surfaced once wallet_pool_store.py became strictly typed.

* Some better types and await ws_server.stop().

---------

Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>

Run Details

10395 of 11567 branches covered (89.87%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 10 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

104796 of 114812 relevant lines covered (91.28%)

1.83 hits per line