blues / note-c / 22673132835

93%

push

github

CRC fixes (#227)

* fix: correct memcmp size argument in _crcError CRC field detection

The third argument to memcmp was ((sizeof(CRC_FIELD_NAME_TEST) - 1)) != 0)
which evaluates != 0 as part of the size expression, yielding boolean 1
instead of the intended length 7. This caused CRC field detection to
compare only 1 byte (a quote character) instead of the full pattern.

This is triggered on Notecard firmware that does not support CRC. A
hub.status response like {"connected":false,"status":"connecting"}
has a quote at the CRC detection offset (position 19 = 41 - 22). The
1-byte compare falsely matches it as a CRC field, permanently setting
notecardFirmwareSupportsCrc=true and causing all subsequent responses
to be flagged as CRC errors.

When the Notecard does support CRC, the real CRC field sits at the
expected offset, so the 1-byte compare accidentally matches correctly.

Add regression tests with a realistic hub.status response that triggers
the bug to verify the fix.

* fix: Missing CRC bug

* fix: early return condition order

* fix: improve invalid JSON test

* fix: typos in comments

---------

Co-authored-by: Matthew McGowan <mat.mcgowan+git@gmail.com>

1195 of 1371 branches covered (87.16%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

2454 of 2538 relevant lines covered (96.69%)

79.81 hits per line