vEnhance / otis-web / 22648463257

94%

push

github

feat(arch): add opt-in setting to disable ARCH hints (#458)

* feat: add opt-in setting to disable ARCH hints

Add UserProfile.disable_hints boolean field that allows users to hide all hints from the problem archive for pedagogical purposes.

* style: apply ruff formatting to migration

* fix: use getattr to satisfy pyright type checking

* refactor: use get_object_or_404 for UserProfile access

Replace nested getattr with get_object_or_404 for better readability,
matching the pattern used elsewhere in the codebase.

* fix: check disable_hints without creating UserProfile

Use filter().exists() to check if user has disabled hints, avoiding
database writes on GET requests. If no UserProfile exists, hints are
shown by default (disable_hints=False).

* feat(arch): improve disable hints UX and security

- Show "hints disabled" message instead of "no hints" when user has disabled hints
- Block direct access to hint detail pages when hints are disabled
- Add link to user preferences for re-enabling hints
- Add comprehensive unit tests for all disable hints scenarios

This prevents confusion where users see "no hints available" when they've
actually disabled hints themselves, and closes a security gap where users
could bypass the hint blocking by accessing detail URLs directly.

* refactor: use elif/else instead of nested conditionals in hint_list template

---------

Co-authored-by: Dean Menezes <dmm3297@my.utexas.edu>

821 of 1052 branches covered (78.04%)

Branch coverage included in aggregate %.

57 of 57 new or added lines in 3 files covered. (100.0%)

8689 of 9100 relevant lines covered (95.48%)

0.95 hits per line