ThePalaceProject / web-patron / 22457475095

77%

push

github

Prevent about:blank flash and fix popup handling in external reader (PP-3706) (#99)

## Description

<!--- Describe your changes -->
Opens a loading page into the new tab synchronously before the async URL
fetch, replacing the about:blank flash. Adds a null guard for blocked
popups with a same-tab fallback. A temporary "Loading..." text displays
in the blank new tab to smooth the transition to the new tab while CPW
fetches the externalReaderUrl for the web reader.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Testing revealed that some browsers like Safari would block the web
reader as a popup, obscuring the reader from a user. By first creating a
blank page then populating with the web reader link, we should be able
to bypass that behavior as the browser interprets these actions as user
initiated and therefore less likely to try and block a popup.

We'll fallback to loading the web reader URL within the same browser
tab, just in case the browser is aggressive about blocking a popup.
<!--- If it fixes an open issue, please link to the issue here. -->

[Jira PP-3706](https://ebce-lyrasis.atlassian.net/browse/PP-3706)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
Added unit tests to simulate opening an externalReaderUrl in a new
browser tab.
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [N/A] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

57 of 74 branches covered (77.03%)

Branch coverage included in aggregate %.

71 of 92 relevant lines covered (77.17%)

11.84 hits per line