stacklok / toolhive / 22634198114

64%

Build Type

push

github

Committed by web-flow

Commit Message

Add Skills HTTP client implementing SkillService interface (#3977)

* Add Skills HTTP client implementing SkillService interface (#3652)

Implement an HTTP client in pkg/skills/client/ that calls the Skills
REST API (/api/v1beta/skills). The Client struct satisfies the
skills.SkillService interface so CLI commands can depend on the
interface and be tested with the existing MockSkillService mock.

This is a new pattern for ToolHive — skills CLI commands go through
the REST API (requires `thv serve` running) rather than calling pkg/
directly like other commands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use httperr.CodedError from toolhive-core instead of custom APIError

Remove pkg/skills/client/errors.go entirely. The client now returns
httperr.CodedError (from toolhive-core/httperr) for API errors, which
is the same type the server-side ErrorHandler already uses. Callers
inspect error codes via httperr.Code(err) directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

135 of 148 new or added lines in 1 file covered. (91.22%)

6 existing lines in 2 files now uncovered.

46500 of 72791 relevant lines covered (63.88%)

75.38 hits per line