bacnet-js / client / 22633679020

85%

push

github

fix(tests): eliminate flaky timers and silent false positives (#75)

## Summary

### Test fixes
- **RequestManager unit tests**: replaced real `setTimeout`/`wait()`
with `t.mock.timers` (Node.js mock timers API) so all timing is fully
deterministic — eliminates the root cause of flaky failures where the
100ms test delay matched the floor in `#scheduleClear()`
- **Unit + integration tests**: replaced `try/catch` patterns with
`assert.rejects()` to prevent silent false positives (previously, if the
promise resolved instead of rejecting, the test passed with zero
assertions)
- **Integration tests**: moved `client.close()` outside the catch block
so it always runs, preventing socket leaks

### CI updates
- Node matrix: `[20, 22]` → `[22, 24]` across all workflows
- Bumped all GitHub Actions to latest major versions:
  - `actions/checkout` v4 → v6
  - `actions/setup-node` v4 → v6
  - `actions/upload-artifact` v4 → v7
  - `actions/download-artifact` v4 → v8
  - `actions/upload-pages-artifact` v3 → v4
  - `github/codeql-action` v3 → v4
  - `coverallsapp/github-action` v2.3.4 → v2.3.6
- Simplified `publish.yml` by removing unnecessary single-entry matrix

Closes #73

## Test plan

- [x] `request-manager.spec.ts` passes 50/50 consecutive runs with zero
failures
- [x] Full unit suite passes (182 tests)
- [x] Full integration suite passes (33 tests)
- [ ] CI workflows pass on PR (Node 22 + 24 matrix)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

1010 of 1491 branches covered (67.74%)

Branch coverage included in aggregate %.

5477 of 6114 relevant lines covered (89.58%)

37.72 hits per line