hyperledger / fabric-x-committer / 22621550981

90%

Build Type

push

github

Committed by web-flow

Commit Message

[connection] Minor fixes (#398)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

This PR introduces minor fixes and improvements to the connection
utilities:

- Sustain function signature update: Added a retry configuration
parameter to `connection.Sustain()` calls across coordinator and sidecar
services. Currently passing `nil` with TODO comments to initialize retry
from config in future updates.
- ClientParameters refactoring: Renamed `Parameters` struct to
`ClientParameters` for better clarity and removed the unused `Resolver`
field from the struct.
- Single endpoint optimization: Added logic in
`newLoadBalancedConnection()` to handle single endpoint cases more
efficiently by directly calling `NewConnection()` instead of setting up
load balancing infrastructure when only one endpoint is provided.
- Load balancer target naming: Replaced "method` with actual target
addresses in `newLoadBalancedConnection()` to create a meaningful target
string for debugging.

These modifications prepare the codebase for future retry configuration
support while improving code clarity and handling edge cases more
efficiently.

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Run Details

30 of 31 new or added lines in 5 files covered. (96.77%)

20 existing lines in 5 files now uncovered.

8918 of 9963 relevant lines covered (89.51%)

1.29 hits per line