stacklok / toolhive / 22620509927

64%

Build Type

push

github

Committed by web-flow

Commit Message

Add SessionManager behind sessionManagementV2 flag (Phase 2) (#3906)

* Add SessionManager behind sessionManagementV2 flag (Phase 2)

Implement RFC THV-0038 Phase 2: a vmcpSessionManager that bridges
the MultiSession/MultiSessionFactory domain logic to the MCP SDK's
SessionIdManager interface. The feature is gated behind a
sessionManagementV2 config flag (default false), leaving the
existing code path completely unchanged when disabled.

Key changes:
  - pkg/vmcp/server/session_manager.go: new vmcpSessionManager with
    two-phase creation — Generate() stores a placeholder, CreateSession()
    (called from OnRegisterSession hook) replaces it with a fully-formed
    MultiSession via MakeSessionWithID(). Terminate() calls Close() before
    deleting to release backend connections. GetAdaptedTools() returns
    SDK tools with session-scoped handlers delegating to CallTool().
  - pkg/vmcp/session/factory.go: add MakeSessionWithID() to the
    MultiSessionFactory interface; refactor MakeSession to share a private
    makeSession() implementation.
  - pkg/transport/session/manager.go: add ReplaceSession() upsert to
    swap a placeholder with a fully-formed MultiSession.
  - pkg/vmcp/config/config.go: add SessionManagementV2 bool field.
  - pkg/vmcp/server/server.go: wire vmcpSessionManager when flag+factory
    are set; add handleSessionRegistrationV2() hook handler.
  - pkg/vmcp/discovery/middleware.go: skip Phase 1 routing-table
    reconstruction for Phase 2 MultiSession sessions.
  - Tests: unit tests for all new methods, ReplaceSession coverage in
    transport/session, and an end-to-end integration test covering
    initialize, tool call routing, and the old-path-unaffected case.

Closes: #3866

* changes from review

---------

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

331 of 373 new or added lines in 8 files covered. (88.74%)

10 existing lines in 3 files now uncovered.

45881 of 72381 relevant lines covered (63.39%)

76.4 hits per line