stacklok / toolhive / 22619272664

64%

Build Type

push

github

Committed by web-flow

Commit Message

Release proxy mutex before draining connections in Stop() (#3970)

Stop() held p.mutex for the entire duration of server.Shutdown(),
which blocks until all active connections close. IsRunning() acquires
the same mutex, so the runner's monitoring goroutine could not detect
that the proxy had stopped.

Fix by releasing the mutex before calling server.Shutdown(). The
shutdown signal (closing shutdownCh) and state updates (stopped flag,
server nil-out) happen under the lock; only the slow drain runs
unlocked. IsRunning() no longer needs the mutex since it only does a
channel select, which is goroutine-safe by design.

Also add a 30-second shutdown timeout with force-close fallback, and
set IdleTimeout on the HTTP server to prevent idle keep-alive
connections from blocking Shutdown() indefinitely.

Fixes #3969

Signed-off-by: Greg Katz <gkatz@indeed.com>

Run Details

36 of 44 new or added lines in 1 file covered. (81.82%)

2 existing lines in 1 file now uncovered.

45483 of 71942 relevant lines covered (63.22%)

74.61 hits per line