briandfoy / pod-perldoc / 22618984356

15%

push

github

Fix approach to pagers and terminals (#79)

* Sync all OS detection lines

* Move inspection of groff into main module (Perldoc.pm) from ToMan.pm:

The ToMan formatter would search for the groff version it has available
but based on CPAN RT #120229, we need to determine this much earlier to
decide whether to pass on to ToMan or not.

This does not make any behavioral changes (other than temporarily
removing a debug message).

* Two helper functions from Pod::Perldoc::BaseTo were moved into
  Perldoc.pm: _get_path_components() and _find_executable_in_path().
* Perldoc.pm now has a method inspect_execs() which tries to find all
  available executables of a given program. It uses data from a new
  helper function, _exec_data(). Currently only nroff is supported.
* From ToMan we removed the code for detecting nroff and instead
  incorporated them in _exec_data() or a new function
  _find_executable() -- both in Perldoc.pm.
* Perldoc.pm's _inspect_execs() now calls _find_executable(),
  _find_executable_in_path(), and _get_path_components().

ToTerm can now be switched to ToMan and everything still works as it did
before, but we are not doing this yet.

The next commit will start addressing the logic for picking ToMan
or ToTerm.

* Clean up existing logic for determining whether to use ToTerm:

This is just too much to read or figure out at once. Instead of every
possible condition (including unless !(...), which is ridiculous), it's
simply the obvious cocnditions: A set of OS's or a check on term.

If I understand this logic correctly (and I had to write some tests to
verify), it means that we are not using ToTerm for Windows, DOS,
AmigaOS, or for the recognized terms listed ("*dumb*", "*emacs*",
"*none*", and "*unknown*". The fallback is ToText. I guess that makes
sense.

* Initialize pager (and more) before formatter classes:

The formatter class will need to know which pagers have been found so it
could determine whether ToTerm is a good option.

* Onl... (continued)

165 of 172 new or added lines in 4 files covered. (95.93%)

765 of 1462 relevant lines covered (52.33%)

10.15 hits per line