Kinto / kinto / 22618407008

100%

master: 100%

push

github

Add type checking (#3668)

* Fix ty type checker errors to make `make lint` pass

Add `ty` type checker to the lint pipeline and resolve all errors across
the codebase using inline `# type: ignore` suppressions, TYPE_CHECKING
guard patterns, and a `_StorageMixin` base class for storage test mixins.
Also fixes a latent bug: `settings.update(extras or None)` → `extras or {}`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix ty type checker warnings to make \`make lint\` pass cleanly

- Replace deprecated \`codecs.open()\` with \`open()\` and \`tempfile.mktemp()\`
  with \`NamedTemporaryFile(delete=False)\`
- Suppress \`unsupported-base\` warnings on colander/zope.interface subclasses
  where ty cannot resolve the metaclass-based MRO
- Suppress \`possibly-missing-attribute\` warnings on \`sqlalchemy.exc\` accesses
  via the optional \`sqlalchemy\` module reference
- Remove two stale \`# type: ignore[attr-defined]\` comments in openapi support

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix CORS broken by instance attrs shadowing class attrs set by init_from_settings()

Instance-level `self.cors_origins = []` in `__init__` shadowed the class-level
`cls.cors_origins` set by `init_from_settings()`, causing all Service instances
to have empty cors_origins and disabling CORS entirely.

Replace instance attribute initializations with class-level type annotations
(no assignment), which satisfy ty without interfering with the class attribute
lookup in get_arguments().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1544 of 1544 branches covered (100.0%)

131 of 131 new or added lines in 28 files covered. (100.0%)

7920 of 7920 relevant lines covered (100.0%)

3.0 hits per line