enboxorg / gitd / 22596904216

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resolve push auth deadlock by delegating token generation to daemon (#165)

* fix: resolve push auth deadlock by delegating token generation to daemon

The credential helper (git-remote-did-credential) was opening the agent's
LevelDB stores directly, which deadlocked when the daemon (gitd serve)
already held the exclusive lock. LevelDB only allows one process to hold
the lock — the second process hangs forever.

Add POST /auth/token endpoint to the git server that generates DID-signed
push credentials using the daemon's already-unlocked identity. Rewrite the
credential helper to call this endpoint when a daemon is running, falling
back to direct agent connection only when no daemon is found.

- Add generateToken callback to GitServerOptions and POST /auth/token route
- Wire token generation in serve.ts using the agent identity's BearerDid
- Rewrite credential-main.ts to prefer daemon endpoint over direct agent
- Add E2E test exercising the real credential helper binary via /auth/token

* test: add real daemon E2E test for push auth LevelDB lock fix

Replaces the in-process E2E test with a real multi-process test:
- test-daemon.ts: standalone daemon process that holds LevelDB lock
- e2e.spec.ts: spawns daemon, verifies /health, /auth/token, clone, push

Fixes: async Array.find() bug, nonce replay in test authenticator,
ownerDid assignment order, unused mkdirSync import.

Run Details

4 of 57 new or added lines in 2 files covered. (7.02%)

1 existing line in 1 file now uncovered.

7837 of 9329 relevant lines covered (84.01%)

28.86 hits per line