15590
77%

Ran 08 Sep 2016 05:07PM UTC

Jobs 1

Files 380

Run time 33s

Badge

Embed ▾

pending completion

Build # 15590

Build Type

push

travis-ci

Committed by

boundsj

Commit Message

[ios, macos] Put MGLStyleLayer inits in respective classes

Previously, we declared MGLStyleLayer initializers in the MGLStyleLayer
protocol as optional methods. This made it easy to opt in and out
of initializers that did or or did not make sense for the subclass.
However, this approach was dangerous since it was easy for an
application developer to initialize an MGLStyleLayer subclass with an
init method that was actually not implemented in that class causing
an exception at runtime.

This commit moves the init methods that each subclass supports to
each subclass so xcode (and the compiler) help the developer avoid
the previously possible runtime exception.

In addition, a new init method is added that takes the source layer
and passes that on to `mbgl::style:Layer` (but only on classes
where this is possible in core). This allows an application developer
to style a specific source layer (i.e. the contour lines of the mapbox
terrain vector source).

Finally, this refactors MGLStyleLayer classes to use an MGLSource instead of a
string identifier for the source when initializing the style.

Coverage Stats

9740 of 12920 relevant lines covered (75.39%)

15440.19 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	15590.2 (BUILDTYPE=Debug _CXX=g++-5 _CC=gcc-5 WITH_COVERAGE=1)	08 Sep 2016 05:07PM UTC	0	75.39	Travis Job 15590.2

Source Files on build 15590

Detailed source file information is not available for this build.

mapbox / mapbox-gl-native / 15590
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15590

mapbox / mapbox-gl-native / 15590 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15590

mapbox / mapbox-gl-native / 15590
77%

README BADGES
x