mozilla / fx-private-relay / 27248121-df67-4761-aaaa-5de5fcf843d0

92%

main: 92%

Build Type

Pull #6345

circleci

Committed by groovecoder

Commit Message

build(frontend): upgrade ESLint v8 to v9, fix all violations

Use `ESLINT_USE_FLAT_CONFIG=false` to keep `.eslintrc.js`. Add explicit
`'./src'` pattern, required by v9 legacy config mode.

ESLint v9 can run some plugins that v8 silently ignored.
Fix all newly-enforced violations:

`react-hooks/globals|/refs|/static-components` (React Compiler rules):
* SSR hydration `useState+useEffect` → `useSyncExternalStore`
* `setState` in effects → `startTransition`
* in `render`:
  * components, ref access → moved to module scope
  * `Date.now()` → `useMemo(() => Date.now(), [])` with eslint-disable
  * `Object.assign` instead of mutation

`testing-library/no-container|no-node-access`:
* `container.querySelector()` → `within()`
* `firstChild` checks → `toBeEmptyDOMElement()`

`testing-library/render-result-naming-convention`:
* render result variable "result" → "view"

`@typescript-eslint/no-explicit-any`:
* `any` → typed or `unknown`

`jest-dom/prefer-empty|prefer-in-document|prefer-to-have-attribute`:
* `toHaveTextContent("")` → `toBeEmptyDOMElement()`
* `toBeNull()` → `not.toBeInTheDocument()`
* `getAttribute("class")` → `toHaveClass()`

`prefer-const`
* `let` → `const` where never reassigned

Pull Request Pull Request #6345: build(frontend): upgrade ESLint v8 to v9, fix all violations

Coverage Stats

3041 of 3901 branches covered (77.95%)

Branch coverage included in aggregate %.

70 of 86 new or added lines in 21 files covered. (81.4%)

1 existing line in 1 file now uncovered.

18822 of 19966 relevant lines covered (94.27%)

14.06 hits per line