stacklok / toolhive / 22583773507

64%

Build Type

push

github

Committed by web-flow

Commit Message

Address PR review feedback on vmcp/session (#3905)

Extract the shared MCP operation methods (CallTool, ReadResource,
GetPrompt, Close) from backend.Session and MultiSession into a new
types.Caller interface in pkg/vmcp/session/types, eliminating
duplication between the two interfaces. This is a first step toward
the future consolidation of the two session types.

Factor the in-flight request tracking logic (sync.RWMutex,
sync.WaitGroup, closed bool) out of defaultMultiSession into a new
AdmissionQueue interface with a concrete admissionQueue implementation.
This makes the concurrency contract independently testable and removes
synchronization noise from the session struct. Snapshot methods
(Tools, Resources, Prompts, BackendSessions) no longer need locks
since those fields are immutable after construction.

Add unit tests for the HTTP round trippers (httpRoundTripperFunc,
authRoundTripper, identityRoundTripper) in the internal/backend
package, covering request cloning, auth error propagation, and
identity context propagation.

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

39 of 39 new or added lines in 3 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

45480 of 71860 relevant lines covered (63.29%)

77.02 hits per line