asmodehn / openwisp-controller / 22572780292
99%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 137
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.672% (+0.03%) from 98.641%
22572780292

push

github

nemesifier 
[chores] Improved WHOIS & Estimated Location features

Fixed multiple issues discovered during testing and review across WHOIS,
estimated location, and device IP handling, and consolidated QA and
maintenance changes.

Key changes:
- Ensure clear_last_ip command calls model save() to trigger signals and
  cache invalidation
- Fix WHOIS and estimated location bugs, including shared location
  recreation and modified timestamp updates
- Improve handling of unchanged IPs in DeviceChecksumView
- Rename and adjust migrations for estimated location settings
- Optimize queries and improve error handling (global HttpError handling)
- Improve UI (CSS/JS/templates) and documentation
- Improved efficiency of `manage_estimated_locations`
- Resolved N+1 query issue in `LocationListCreateView`
- Fixed HTTP request inside `transaction.atomic()`
- Shifted to Celery `send_task` to retain dependency flow
- Removed whois info from device list API to avoid N+1
- Simplified auto-naming of estimated locations
- Updated location update description messages
- Increased WHOIS refresh threshold to 90 days (~92% reduction in API calls)
- WHOIS data refresh now executes on transaction commit
- Skips `delete_whois_record` if `initial_ip_address` is None
- Fixed late-binding closure issue with `_initial_last_ip`
- Error notifications now only sent if `device_pk` is not None
- CIDR field length increased to accommodate IPv6
- Added `is_estimated` filter and column to admin
- Added `is_estimated` to `LocationSerializer` and API filter
- Improved test coverage
- Fixed parallel test 401 errors
- Several other improvements and fixes for problems found during testing

Co-authored-by: DragnEmperor <dragnemperor@gmail.com>
Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>

7279 of 7377 relevant lines covered (98.67%)

10.85 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
99.43
 0.0% config/api/serializers.py
1
98.51
 2.08% config/base/multitenancy.py
1
97.78
 -2.22% config/settings.py
1
98.89
 0.38% config/utils.py
1
98.61
 -1.39% geo/base/models.py
2
98.23
 0.1% config/tasks.py
2
97.83
 -0.34% config/tasks_zerotier.py
2
98.29
 2.29% geo/admin.py
4
99.28
 0.02% config/admin.py
4
98.46
 0.11% config/base/device.py
4
98.29
 -1.71% geo/api/serializers.py
4
98.1
 0.07% geo/api/views.py
Jobs
ID Job ID Ran Files Coverage
1 python- - 22572780292.1 137
98.67
 GitHub Action Run
Source Files on build 22572780292