kubeovn / kube-ovn / 22563793962

24%

push

github

fix(e2e): stabilize ANP domain E2E tests and fix hasDomainNames override bug (#6376)

The ANP domain E2E test "should dynamically add and remove domainName
deny rules in a single ANP" was flaky due to insufficient retry window
for DNS resolution. The CoreDNS dnsnameresolver plugin works reactively,
only intercepting DNS queries that flow through CoreDNS. When a domain
is already cached (e.g., google.com with 300s TTL), the plugin cannot
intercept queries until the cache expires, causing the address set to
remain empty and the deny rule to never take effect.

Fix the flaky tests by aligning with the already-fixed CNP domain tests:
- Add waitForDNSResolversCreated() to ensure DNSNameResolver CRs are
  created before testing deny rules
- Increase retry parameters from 20x1s to 30x3s to allow sufficient
  time for DNS resolution and OVN propagation

Also fix a bug in admin_network_policy.go where hasDomainNames was being
overwritten instead of accumulated across peers in a rule. When a rule
had multiple peers with the first having domain names but the last not,
hasDomainNames would incorrectly be set to false, potentially skipping
ACL creation.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

0 of 1 new or added line in 1 file covered. (0.0%)

12561 of 54402 relevant lines covered (23.09%)

0.27 hits per line