ehtick / gdal / 22555277629
74%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 2053
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.844%. Remained the same
22555277629

push

github

web-flow 
CMake: MacOSX framework build fix (#13945)

* CMake/helpers/GdalVersion: fix MacOS framework build with BYPRODUCTS in custom target

In a standard build the compiler finds
`gcore/gdal_version_full/gdal_version.h` implicitly from the
search directory.

In a framework build the file must be copied into the app bundle.
However, because Ninja is strict, it refuses to do so unless the file
is explicitely associated with a rule known to create it.

See the below error when building with `GDAL_ENABLE_MACOSX_FRAMEWORK`:

`ninja: error: 'gcore/gdal_version_full/gdal_version.h', needed by 'gdal.framework/Versions/3.13/Headers/gdal_version.h', missing and no known rule to make it`

`BYPRODUCTS` explicitely registers the header as a byproduct of the
custom CMake target so that Ninja has an associated rule with it.

Further reading:

 - https://cmake.org/cmake/help/latest/command/add_custom_target.html
 - https://cmake.org/cmake/help/latest/policy/CMP0058.html

* CMake/gdal.cmake: comply with Apple metadata policy when building MacOS framework

When `GDAL_ENABLE_MACOSX_FRAMEWORK` is used, the framework produced by
Cmake does not comply with the requirements set by the Apple
documentation.

The CMake target properties `MACOSX_FRAMEWORK_SHORT_VERSION_STRING` and
`MACOSX_FRAMEWORK_BUNDLE_VERSION`, which map respectively to
`CFBundleShortVersionString` and `CFBundleVersion` in the produced
`Info.plist` of the framework, must respect the following guidelines:

- `CFBundleShortVersionString`: "This key is a user-visible string for
  the version of the bundle. The required format is three
  period-separated integers, such as 10.14.1. The string can only
  contain numeric characters (0-9) and periods."
  Source: https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundleshortversionstring

- `CFBundleVersion`: "This key is a machine-readable string composed of
  one to three period-separated integers, such as 10.14.1. The string
  can only... (continued)

610135 of 849244 relevant lines covered (71.84%)

320203.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
289
90.49
 -0.05% ogr/ogrsf_frmts/gpkg/ogrgeopackagetablelayer.cpp
136
92.02
 0.22% alg/gdalgrid.cpp
6
71.5
 -0.57% third_party/LercLib/Lerc2.h
5
54.55
 -0.13% frmts/gtiff/libtiff/tif_dirwrite.c
4
34.66
 0.02% frmts/gtiff/libtiff/tif_dirread.c
4
69.43
 -1.51% port/cpl_vsisimple.cpp
2
44.32
 -0.45% frmts/gtiff/libtiff/tif_dirinfo.c
2
79.96
 -0.36% frmts/gtiff/libtiff/tif_predict.c
2
70.9
 -0.22% port/cpl_error.cpp
2
78.95
 -0.4% port/cpl_multiproc.cpp
2
40.25
 -0.21% port/cpl_virtualmem.cpp
2
89.41
 -0.09% port/cpl_vsil.cpp
2
87.74
 -0.12% port/cpl_vsil_curl_streaming.cpp
1
97.57
 -0.03% autotest/cpp/test_cpl.cpp
1
53.48
 0.0% frmts/gtiff/libtiff/tif_dir.c
1
62.59
 -0.24% frmts/gtiff/libtiff/tif_webp.c
1
84.18
 -0.63% frmts/wms/gdalhttp.cpp
1
91.14
 -0.63% frmts/wms/gdalwmscache.cpp
1
87.81
 0.77% ogr/ogrsf_frmts/mitab/mitab_mapindexblock.cpp
1
78.34
 -0.09% port/cpl_conv.cpp
1
90.31
 -0.44% port/cpl_worker_thread_pool.cpp
1
88.64
 -0.32% third_party/LercLib/Huffman.cpp
1
51.96
 -0.56% third_party/LercLib/Lerc.cpp
Jobs
ID Job ID Ran Files Coverage
1 22555277629.1 2053
71.84
 GitHub Action Run
Source Files on build 22555277629