OSGeo / gdal / 22554086173
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 2053
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.845% (+0.002%) from 71.843%
22554086173

push

github

web-flow 
CMake: MacOSX framework build fix (#13945)

* CMake/helpers/GdalVersion: fix MacOS framework build with BYPRODUCTS in custom target

In a standard build the compiler finds
`gcore/gdal_version_full/gdal_version.h` implicitly from the
search directory.

In a framework build the file must be copied into the app bundle.
However, because Ninja is strict, it refuses to do so unless the file
is explicitely associated with a rule known to create it.

See the below error when building with `GDAL_ENABLE_MACOSX_FRAMEWORK`:

`ninja: error: 'gcore/gdal_version_full/gdal_version.h', needed by 'gdal.framework/Versions/3.13/Headers/gdal_version.h', missing and no known rule to make it`

`BYPRODUCTS` explicitely registers the header as a byproduct of the
custom CMake target so that Ninja has an associated rule with it.

Further reading:

 - https://cmake.org/cmake/help/latest/command/add_custom_target.html
 - https://cmake.org/cmake/help/latest/policy/CMP0058.html

* CMake/gdal.cmake: comply with Apple metadata policy when building MacOS framework

When `GDAL_ENABLE_MACOSX_FRAMEWORK` is used, the framework produced by
Cmake does not comply with the requirements set by the Apple
documentation.

The CMake target properties `MACOSX_FRAMEWORK_SHORT_VERSION_STRING` and
`MACOSX_FRAMEWORK_BUNDLE_VERSION`, which map respectively to
`CFBundleShortVersionString` and `CFBundleVersion` in the produced
`Info.plist` of the framework, must respect the following guidelines:

- `CFBundleShortVersionString`: "This key is a user-visible string for
  the version of the bundle. The required format is three
  period-separated integers, such as 10.14.1. The string can only
  contain numeric characters (0-9) and periods."
  Source: https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundleshortversionstring

- `CFBundleVersion`: "This key is a machine-readable string composed of
  one to three period-separated integers, such as 10.14.1. The string
  can only... (continued)

610137 of 849244 relevant lines covered (71.84%)

320125.46 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
53.48
 -0.08% frmts/gtiff/libtiff/tif_dir.c
1
57.11
 0.0% frmts/gtiff/libtiff/tif_write.c
1
70.9
 1.09% port/cpl_error.cpp
1
87.86
 -0.13% port/cpl_minixml.cpp
1
87.45
 -0.43% third_party/LercLib/Lerc2.cpp
2
44.32
 -0.45% frmts/gtiff/libtiff/tif_dirinfo.c
2
34.73
 0.12% frmts/gtiff/libtiff/tif_dirread.c
2
79.96
 -0.18% frmts/gtiff/libtiff/tif_predict.c
2
40.04
 -0.21% port/cpl_virtualmem.cpp
2
75.87
 -0.07% port/cpl_vsil_curl.cpp
2
69.81
 0.38% port/cpl_vsisimple.cpp
2
82.05
 -5.13% third_party/LercLib/BitStuffer2.h
3
54.8
 0.0% frmts/gtiff/libtiff/tif_dirwrite.c
3
66.22
 -0.45% frmts/gtiff/libtiff/tif_read.c
3
79.15
 -0.4% port/cpl_multiproc.cpp
4
71.4
 -0.1% third_party/LercLib/Lerc2.h
6
49.16
 -3.35% third_party/LercLib/Lerc.cpp
136
92.02
 0.22% alg/gdalgrid.cpp
287
90.54
 0.05% ogr/ogrsf_frmts/gpkg/ogrgeopackagetablelayer.cpp
Jobs
ID Job ID Ran Files Coverage
1 22554086173.1 2053
71.84
 GitHub Action Run
Source Files on build 22554086173