kcl-lang / kcl-go / 22546936236

26%

push

github

fix(gen-jsonschema): fix allOf $ref schema naming and sort closure bugs (#526)

Three bugs in the JSON schema to KCL generator caused schemas using the
allOf + placeholder-properties pattern (e.g., cloud-init) to produce
incorrect output:

1. Sort closure variable shadowing: sort.SliceStable closures used i,j
   parameter names that shadowed the outer loop variable, causing $ref
   (order 0) to sort after properties (order 2), so properties were
   converted before allOf refs could merge in real types.

2. Empty placeholder properties not replaced: when merging allOf member
   properties into an existing schema, properties with empty keyword
   sets (placeholder schemas like "count": {}) were silently skipped
   instead of being replaced with the typed schema from the allOf member.

3. $ref residue causing wrong schema names: the first $ref encountered
   in an allOf fell through to default: and was stored in s.Keywords
   rather than resolved, causing the main keyword loop to later set
   reference = "#/$defs/first_ref" and derive the schema name from it
   instead of from $id or the filename. Fixed by adding case
   *jsonschema.Ref: to the outer allOf switch so all refs are always
   resolved into schs immediately.

Adds a minimal regression test (allof-placeholder-props) and the
previously missing cloud-init/expect.k test fixture.

Signed-off-by: Richard Hillmann <richard@flowers-software.de>

24 of 32 new or added lines in 1 file covered. (75.0%)

4061 of 15582 relevant lines covered (26.06%)

1.79 hits per line