alandtse / alexa_media_player / 22513518631

23%

push

github

refactor: avoid set name collision (#3396)

Issue identified during review of PR #3390
Reported by: @coderabbitai
Requested by: @alandtse

Description:
In custom_components/alexa_media/metrics.py around lines 46-122, the
DataCache.set method name shadows Python's built-in set type.

Current implementation:

def set(self, key: str, value: Any) -> None:
Suggested improvement:
Rename to a clearer name that doesn't shadow built-ins, such as:

cache_set
store
put
Impact:
Nitpick - No runtime problem since it's a method, but better practice to
avoid shadowing built-ins for code clarity.

Reference:

PR: chore: release 2026-02-21 #3390
File: custom_components/alexa_media/metrics.py:46-122

Fixes: #3394

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Renamed an internal caching API for consistency; no change to behavior
or user-facing functionality.
* Startup data handling remains unchanged; users should notice no
functional impact.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

1 of 2 new or added lines in 2 files covered. (50.0%)

1133 of 4765 relevant lines covered (23.78%)

0.24 hits per line