CMU-313 / nodebb-spring-26-team-f1 / 22512201521

79%

push

github

Merge pull request #28 from CMU-313/notifications/pop-up/topics

Implemented popup notifications when someone responds to your message

Code Review(completed by Alexandra)-Popup Notifications Feature

I think this was a very well implemented feature and adds a lot of value to the platform.

Done well:
Correct trigger point: notification logic runs after post save and only for replies
Self-reply prevention: explicit isSelfReply check before emitting.
Clickable popup: includes topicId + postId so the client can navigate to the exact reply.

Suggestions:
Avoid using the global alert()
In public/src/sockets.js, alerts.alert(params) is called and then call alert({ ... }) again. I’d recommend using NodeBB’s alerts module for consistency or one or the other.

11849 of 16946 branches covered (69.92%)

Branch coverage included in aggregate %.

12 of 13 new or added lines in 1 file covered. (92.31%)

25703 of 30810 relevant lines covered (83.42%)

1489.19 hits per line