bitcoindevkit / bdk_wallet / 22369951820

86%

master: 85%

push

github

Merge bitcoindevkit/bdk_wallet#365: [backport] Add get_pre_1_wallet_keychains migration helper

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/f19c6fbf2d309dd262b6d96d81da97db8f46648a">f19c6fbf2 feat[rusqlite]: add get_pre_1_wallet_keychains migration helper (Steve Myers)

Pull request description:

  ### Description

  Add `wallet/migration` module and `get_pre_1_wallet_keychains()` to help migrate users from a pre-1.0 bdk sqlite database. This new function returns the last revealed index and checksum value for each keychain it finds.

  ### Notes to the reviewers

  This is a backport to the `release/2.x` branch of bitcoindevkit/bdk_wallet#364.

  ### Changelog notice

  * Add `get_pre_1_wallet_keychains` to assist migration from pre-1.0 bdk wallets. (back ported from 3.x)

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `just p` before pushing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  thunderbiscuit:
    Tested ACK f19c6fbf2d309dd262b6d96d81da97db8f46648a.
  110CodingP:
    ACK [f19c6fb](https://github.com/bitcoindevkit/bdk_wallet/pull/365/commits/f19c6fbf2d309dd262b6d96d81da97db8f46648a)

Tree-SHA512: 48ec3208700c5b35c9619aeefe3ae2456b4

65 of 72 new or added lines in 1 file covered. (90.28%)

7130 of 8331 relevant lines covered (85.58%)

3129.03 hits per line